Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent group signals to kill engine processes #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leonhfr
Copy link

@leonhfr leonhfr commented Sep 11, 2022

The issue happens when implementing cancellation and graceful shutdown for interrupt signals, for example in a CLI when a user presses CTRL+C. We capture the signals and prevent the immediate exit. The expected behavior would be for the parent application to have control over when the engine subprocess ends and eventually kill it with uci.Engine.Close() while handling its shutdown.

However, the shell signal the entire process group when pressing CTRL+C. Therefore the engine subprocess is killed immediately and the parent process loses control. If waiting on engine output, it is left hanging.

To prevent the shell from signaling the children, we need to start the command in its own process group. This PR implements this.

If having the engine subprocess in the same process group as the parent is sometimes desirable, then alternatively it would be nice to have an option to control the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant