Prevent group signals to kill engine processes #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue happens when implementing cancellation and graceful shutdown for interrupt signals, for example in a CLI when a user presses CTRL+C. We capture the signals and prevent the immediate exit. The expected behavior would be for the parent application to have control over when the engine subprocess ends and eventually kill it with
uci.Engine.Close()
while handling its shutdown.However, the shell signal the entire process group when pressing CTRL+C. Therefore the engine subprocess is killed immediately and the parent process loses control. If waiting on engine output, it is left hanging.
To prevent the shell from signaling the children, we need to start the command in its own process group. This PR implements this.
If having the engine subprocess in the same process group as the parent is sometimes desirable, then alternatively it would be nice to have an option to control the behavior.