Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiPV support to uci.SearchResults #115

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

cmitsakis
Copy link

I added some more commits to PR #100
closes #99

In kmorrison's PR, I noticed is that if you do a MultiPV search, eng.SearchResults().Info shows the score of the last MultiPV result which is the worst move, so the score is wrong. I fixed this issue.

I also changed the type of MultiPV from []*Info to []Info.

@cmitsakis
Copy link
Author

kmorrison's implementation assumes the info line with multipv 1 is printed before the others. This is probably always true in practice, but the UCI protocol does not require it's printed first. It doesn't specify any order. It only requires they are in consecutive lines. I can fix this if you think it's an issue worth fixing.

@valentinEmpy
Copy link

Any progress on merging this?
It'd be extremely useful.

@kogan69
Copy link

kogan69 commented Feb 8, 2023

Hi, everyone!
Any idea when it will be merged into master?
I wait for it impatiently :)
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MultiPV UCI search
4 participants