Fix for vulnerability https://github.com/notnoop/java-apns/issues/286… #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is exchanged with latest version of apache httpclient which does not have any known security issues. The previous test case has been updated to automatically setup proxy with auth and a basic http server to test the tunnel (it can still be reconfigured to test your local proxy/server combo) The new httpclient does not allow the same way of figuring out which credential protocol is used, but I think that the functionality is basically the same. Implementing the change described in notnoop#287 will improve the credentials support further.
|
Is there some problem with the Travis CI? |
added 10 commits
June 3, 2016 12:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… The old commons httpclient library is exchanged with latest version of apache httpclient which does not have any known security issues. The previous test case has been updated to automatically setup proxy with auth and a basic http server to test the tunnel (it can still be reconfigured to test your local proxy/server combo) The new httpclient does not allow the same way of figuring out which credential protocol is used, but I think that the functionality is basically the same. Implementing the change described in #287 will improve the credentials support further.