Only deploy on release

This changes the Rinkeby deploy behavior to only ocurr on release creation. To reduce excess deployments.
nounsDAO · Jun 5, 2021 · 4c78e07 · 4c78e07
1 parent 8bb23a5
commit 4c78e07
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 46 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
diff --git a/.github/workflows/contract-deployment.yaml b/.github/workflows/contract-deployment.yaml
@@ -0,0 +1,55 @@
+name: Contracts CD
+
+on:
+  release:
+    types: 
+      - created
+
+jobs:
+  build_and_test:
+    name: Build and Test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 14.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 14.x
+      - run: yarn 
+      - run: yarn build
+      - name: Run contract tests
+        run: |
+          cd packages/nouns-contracts
+          yarn test
+  build_and_deploy:
+    name: Build and Deploy
+    needs: build_and_test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js 14.x
+        uses: actions/setup-node@v1
+        with:
+          node-version: 14.x
+      - run: yarn 
+      - run: yarn build
+      - name: Deploy contract to Rinkeby
+        env:
+          INFURA_PROJECT_ID: ${{ secrets.INFURA_PROJECT_ID }}
+          MNEMONIC: ${{ secrets.MNEMONIC }}
+        run: |
+          cd packages/nouns-contracts
+          npx hardhat run --network rinkeby scripts/deploy-ci.ts
+      - name: Verify contract on Etherscan
+        env:
+          INFURA_PROJECT_ID: ${{ secrets.INFURA_PROJECT_ID }}
+          ETHERSCAN_API_KEY: ${{ secrets.ETHERSCAN_API_KEY }}
+        run: |
+          cd packages/nouns-contracts
+          echo "Giving Etherscan time to index"
+          sleep 60 # This could be replaced by polling etherscan on that address, wait for non-404
+          npx hardhat verify --network rinkeby `cat logs/deploy.json| jq -r '.contractAddress'`
+      - name: Look here for contract info
+        run: |
+          cd packages/nouns-contracts
+          echo "Contract deployed on Rinkeby to `cat logs/deploy.json| jq -r '.contractAddress'`"
diff --git a/.github/workflows/contracts.yaml b/.github/workflows/contracts.yaml
@@ -24,35 +24,3 @@ jobs:
         run: |
           cd packages/nouns-contracts
           yarn test
-  build_and_deploy:
-    name: Build and Deploy
-    needs: build_and_test
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - name: Use Node.js 14.x
-        uses: actions/setup-node@v1
-        with:
-          node-version: 14.x
-      - run: yarn 
-      - run: yarn build
-      - name: Deploy contract to Rinkeby
-        env:
-          INFURA_PROJECT_ID: ${{ secrets.INFURA_PROJECT_ID }}
-          MNEMONIC: ${{ secrets.MNEMONIC }}
-        run: |
-          cd packages/nouns-contracts
-          npx hardhat run --network rinkeby scripts/deploy-ci.ts
-      - name: Verify contract on Etherscan
-        env:
-          INFURA_PROJECT_ID: ${{ secrets.INFURA_PROJECT_ID }}
-          ETHERSCAN_API_KEY: ${{ secrets.ETHERSCAN_API_KEY }}
-        run: |
-          cd packages/nouns-contracts
-          echo "Giving Etherscan time to index"
-          sleep 60 # This could be replaced by polling etherscan on that address, wait for non-404
-          npx hardhat verify --network rinkeby `cat logs/deploy.json| jq -r '.contractAddress'`
-      - name: Look here for contract info
-        run: |
-          cd packages/nouns-contracts
-          echo "Contract deployed on Rinkeby to `cat logs/deploy.json| jq -r '.contractAddress'`"