DAO V3.1: fix vote gas refund #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we accidentally used the old V2 code that refunds msg.sender it should be tx.origin to refund gas payers of multisigs
✅ Deploy Preview for nouns-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nouns-home ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eladmallel
commented
Nov 7, 2023
packages/nouns-contracts/test/governance/NounsDAO/V3/voteRefund.test.ts
Outdated
Show resolved
Hide resolved
|
@eladmallel can we update the original |
we want to stop maintaining tests on prev versions instead make sure all tests run against the latest version
there's a test file for V2 with the same logic
this is testing V1 there's a forge test for V2 with the same logic
it's available in the V1 tag
we don't want gov tests for older versions anymore
cancel tests were already duplicated withdraw test now migrated
davidbrai
reviewed
Nov 14, 2023
|
@eladmallel LGTM |
solimander
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we accidentally used the old V2 code that refunds msg.sender it should be tx.origin
to refund gas payers of multisigs