Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes: update proposalBySigs flow #817

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

ripe0x
Copy link
Contributor

@ripe0x ripe0x commented Nov 18, 2023

  1. there was a bug in the Edit Candidate form that wasn't passing proposalIdToUpdate when it should. resolved.
  2. Edit Proposal form had a bug that resulted in the page not loading the proposal content properly when reloaded. resolved.
  3. Edit Proposal form validation was being bypassed if the proposal content wasn't properly loaded on reload (see add img permutator to test nouns autogen #2). resolved.
  4. when updating a proposalBySigs without editing the title, there was an error because the slug of the candidate being created conflicted with the original candidate. resolved.

… sometimes not displaying prop content, add update-slug function to create a unique slug for update candidates with the same title
Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for nouns-testnet ready!

Name Link
🔨 Latest commit a7977e4
🔍 Latest deploy log https://app.netlify.com/sites/nouns-testnet/deploys/655914dd05ebe80008506a1f
😎 Deploy Preview https://deploy-preview-817--nouns-testnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@solimander solimander merged commit f32274b into nounsDAO:master Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants