Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamEscrow #866

Open
wants to merge 106 commits into
base: master
Choose a base branch
from
Open

StreamEscrow #866

wants to merge 106 commits into from

Conversation

davidbrai
Copy link
Collaborator

No description provided.

@davidbrai
initial poc code from escrowed streams
018a92c
@davidbrai
fix bug
a50aa50
@davidbrai
add tests
5a7aa57
@davidbrai
first auction doesn't stream yet
66f8ca9
@davidbrai
immediately stream remainder
807fad7
@davidbrai
cant cancel finished stream
dc55686
@davidbrai
forward streams only if 24 hours passed
1b39ffb
@davidbrai
add auction house setter
36d29dc
@davidbrai
add a cancel multiple streams convenience function
89fa882
@davidbrai
add event
b29dd94
@davidbrai
rename
c2ac8cc
@davidbrai
rename auction house from v2 to v3
90460ab 
change tests to immediately deploy AH v3
still have some commented out files to deal with later
@davidbrai
update auction house upgrade fork test
4c5e222
@davidbrai
cleanup
cea51ca
@davidbrai
change stream permissions
0bd01f3 
any noun owner can create a stream if it doesn't exist
anyone can forward the streams if 24 hours have passed
@davidbrai
stream escrows: rename auctions to ticks
cc80771
@davidbrai
send streamed eth to treasury immediately
0e7f233
@davidbrai
rename var
417153f
@davidbrai
rename var
226c9a6
@davidbrai
cleanup
41c33c5
@davidbrai
cleanup
7dc3fe0
@davidbrai
add ethRecipient and nounsRecipient addresses settable by daoExecutor
1e8607c
@davidbrai
bugfix
bab1657
@davidbrai
refactor finish streams
8c7ed73 
saving the total amount of ethPerTick that stopped streaming at each
tick, instead of saving the streamIds in a list and going over them

this results in less storage writes & reads
@davidbrai
added fastForward function
657ba6a
@davidbrai
better require statements
c24bf96
@davidbrai
rename ticks to currentTick
92d1a20
@davidbrai
create stream: must be whitelisted and noun owner or approved
657dd70
@davidbrai
add setAllowedToCreateStream
911bf00
@davidbrai
remove todo
7601506
davidbrai and others added 27 commits November 20, 2024 16:32
@davidbrai
Merge branch 'verbs-stream-escrow-nouner-can-create-stream' into verb…
f2ee6d0 
…s-stream-escrow-subgraph
@davidbrai
add fastForwardMultipleStreams
79bb07f
@eladmallel
subgraph: update stream escrow ABI and set stream start tick
47394bd
@eladmallel
subgraph: fix bug
8395db0
@eladmallel
subgraph: update ethStreamedPerTick on more events
cf241d1
@davidbrai
Merge pull request #869 from nounsDAO/verbs-stream-escrow-subgraph
7949033 
DRAFT: stream escrow subgraph
@eladmallel
subgraph: new sepolia config for stream escrow
eb6194b
@eladmallel
subgraph: fix missing stream per tick update
d789cf3
@eladmallel
subgraph: fix past streams saving
09d5d0d 
the previous code did not save anything into pastStreams
@davidbrai
add unstreamedETHForNoun
172db75
@davidbrai
add test
f1c4fdf
@davidbrai
don't allow nounsRecipient to be zero address
a1d38e3 
this will cause cancels to revert
@davidbrai
add natspec
8888e0d
@davidbrai
minor refactor and natspec
eaab477
@davidbrai
Merge pull request #870 from nounsDAO/verbs-stream-escrow-unstreamed-…
41c3b43 
…eth-for-noun

DRAFT: add unstreamedETHForNoun
@davidbrai
refactor to follow checks-effects-interactions
d9ec4b5
@davidbrai
Merge remote-tracking branch 'origin/verbs-stream-escrow-fix-audit-is…
4285edb 
…sue-184' into verbs-stream-escrow-audit-fixes
@davidbrai
use safeTransfer when rescuing tokens
8df901f
@davidbrai
Merge pull request #873 from nounsDAO/verbs-stream-escrow-audit-fixes
adede58 
StreamEscrow fixes post sherlock audit
@davidbrai
pin subgraph ci on ubuntu 22
90a5dcd 
see: LimeChain/matchstick#427
and: actions/runner-images#10636
@davidbrai
add subgraph ci file to trigger ci
55e3892
@davidbrai
Merge pull request #874 from nounsDAO/verbs-stream-escrow-fix-subgrap…
eee11e5 
…h-ci

fix subgraph ci
@davidbrai
add view function for ticksLeft in stream
aa116ec
@davidbrai
cleanup
00edb18
@davidbrai
add sherlock audit for stream escrow
308b52d
@davidbrai
add deployment info
575b15b
@davidbrai
Merge pull request #875 from nounsDAO/verbs-stream-escrow-add-ticks-left
c46406b 
add view function for ticksLeft in stream
@eladmallel eladmallel changed the title DRAFT: StreamEscrow StreamEscrow Dec 12, 2024
@eladmallel eladmallel marked this pull request as ready for review December 12, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladmallel eladmallel eladmallel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidbrai @eladmallel @dmrazzy