Add testing tools from master branch #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheapHasz
reviewed
Dec 22, 2017
| test-behavior: docker-up ## launch behavior tests | ||
| ./scripts/waitForElastic.sh | ||
| ./vendor/bin/behat | ||
| make docker-down |
There was a problem hiding this comment.
is that really a wanted behaviour, to make docker up and down each time ?
Wouldn't it be wiser to add that overhead only for the full test suite, which would allow using test-behaviour several time in succession without all the overhead while doing it manually, and keeping the automation in the full test ?
And also, why is there docker-up without make, and make docker-up some lines after ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same testing tools than the master branch