fix(stop): use start/stop interface on mDNS to correctly stop servers (…

…#2)

lib/rtsp.js

@@ -29,6 +29,17 @@ function RtspServer(options, external) {
 }
 
 RtspServer.prototype.connectHandler = function(socket) {
+
+  if (this.handling && !this.clientConnected) {
+    socket.end();
+    return;
+  }
+
+  this.socket = socket;
+  this.handling = this.socket;
+
+  socket.id = new Date().getTime();
+
   const parser = new ServerParser(socket, {
     protocol: 'RTSP/1.0',
     statusMessages: {
@@ -135,4 +146,8 @@ RtspServer.prototype.disconnectHandler = function(socket) {
   }
 };
 
+RtspServer.prototype.stop = function() {
+  this.rtp.stop()
+}
+
 module.exports = RtspServer;

lib/server.js

@@ -78,17 +78,34 @@ NodeTunes.prototype.start = function(callback) {
       } else {
         debug('server running without broadcast (on port %s)', port);
       }
-      callback(null,{
-        port,
-        macAddress: this.options.macAddress,
+    }
+
+    this.netServer = net.createServer(this.rtspServer.connectHandler.bind(this.rtspServer)).listen(port, function() {
+      this.advertisement = mdns.createAdvertisement(mdns.tcp('raop'), port, {
+        name: this.options.macAddress + '@' + this.options.serverName,
+        txtRecord: this.txtSetup,
       });
-    });
-  });
+      this.advertisement.start()
+
+      if (callback) {
+        callback(null, {
+          port: port,
+          macAddress: this.options.macAddress,
+        });
+
+      }
+
+      debug('broadcasting mdns advertisement (for port %s)', port);
+
+    }.bind(this));
+  }.bind(this));
 };
 
 NodeTunes.prototype.stop = function() {
   debug('stopping nodetunes server');
   this.netServer.close();
+  this.rtspServer.stop();
+  this.advertisement.stop();
 };
 
 module.exports = NodeTunes;