Fix --uppercase=false not working #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes nrempel#16 Fixes the value of the uppercase option always being true. This was due to the design of claps boolean flags which is discussed here: clap-rs/clap#1649 (comment) This PR uses the solution mentioned in the linked comment from that thread. Using `require_equals` and `default_missing_value` allows `sleek --uppercase "queries/*sql"` to still work without trying to parse the path as the uppercase boolean, reducing breakage. Use `--uppercase=false` to disable uppercase, NOT `--uppercase false`.
|
Somehow I missed that #17 already exists. That would be an acceptable solution as well. It's slightly different though so I'll leave this open for now. Feel free to close this if you decide to go with the other PR. |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Fixes the value of the uppercase option always being true. This was due to the design of claps boolean flags which is discussed here: clap-rs/clap#1649 (comment)
This PR uses the solution mentioned in the linked comment from that thread.
Using
require_equalsanddefault_missing_valueallowssleek --uppercase "queries/*sql"to still work without trying to parse the path as the uppercase boolean, reducing breakage.Use
--uppercase=falseto disable uppercase, NOT--uppercase false.