Fix infinite recursion when you link gearboxes in a loop #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mista-Tea
added a commit
to IJWTB/ACF
that referenced
this pull request
May 7, 2020
… in a loop norrbotten commented on Aug 19, 2019 "Its possible to link gearboxes in a loop which causes some some pretty bad issues when you power it. Example of such setup https://i.imgur.com/qLvHx9R.jpg This fix stops people from linking gearboxes in loops by basically just searching the links from the target gearbox back to the source. If the source is found the link will fail. It doesn't actually fix the issue of the infinite recursion itself, it just makes it impossible to create the setup needed for it. After fix https://i.imgur.com/9HHZFqh.jpg"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its possible to link gearboxes in a loop which causes some some pretty bad issues when you power it.
Example of such setup
This fix stops people from linking gearboxes in loops by basically just searching the links from the target gearbox back to the source. If the source is found the link will fail. It doesn't actually fix the issue of the infinite recursion itself, it just makes it impossible to create the setup needed for it.
After fix