fix(react): types should be in compilerOptions of tsconfig.spec.json (#…

…20290)
nrwl · Nov 16, 2023 · 4bd4ec2 · 4bd4ec2
1 parent 353bf0f
commit 4bd4ec2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/react/src/generators/application/application.spec.ts b/packages/react/src/generators/application/application.spec.ts
@@ -64,6 +64,8 @@ describe('app', () => {
         'vite/client',
         'node',
         'vitest',
+        '@nx/react/typings/cssmodule.d.ts',
+        '@nx/react/typings/image.d.ts',
       ]);
     });
 

diff --git a/packages/react/src/generators/application/lib/update-jest-config.ts b/packages/react/src/generators/application/lib/update-jest-config.ts
@@ -8,15 +8,17 @@ export function updateSpecConfig(host: Tree, options: NormalizedSchema) {
   }
 
   updateJson(host, `${options.appProjectRoot}/tsconfig.spec.json`, (json) => {
-    json.types = json.types || [];
+    const compilerOptions = json.compilerOptions ?? {};
+    const types = compilerOptions.types ?? [];
     if (options.style === 'styled-jsx') {
-      json.types.push('@nx/react/typings/styled-jsx.d.ts');
+      types.push('@nx/react/typings/styled-jsx.d.ts');
     }
-    json.types = [
-      ...json.types,
+    types.push(
       '@nx/react/typings/cssmodule.d.ts',
-      '@nx/react/typings/image.d.ts',
-    ];
+      '@nx/react/typings/image.d.ts'
+    );
+    compilerOptions.types = types;
+    json.compilerOptions = compilerOptions;
     return json;
   });