Skip to content

Commit

Permalink
chore(repo): temporarily allow linking to vue (#19591)
Browse files Browse the repository at this point in the history
  • Loading branch information
FrozenPandaz authored Oct 12, 2023
1 parent 37e5941 commit 57247e0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion nx-dev/nx-dev/next-sitemap.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const path = require('path');
module.exports = {
siteUrl: process.env.SITE_URL || 'https://nx.dev',
generateRobotsTxt: true,
exclude: ['/ai'],
exclude: [],
sourceDir: path.resolve(__dirname, '../../dist/nx-dev/nx-dev/.next'),
outDir: path.resolve(__dirname, '../../dist/nx-dev/nx-dev/public'),
};
6 changes: 6 additions & 0 deletions scripts/documentation/internal-link-checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ function checkLinkIsForPrivatePackage(link: string) {
}
const pathSegments = link.split('/').filter(Boolean);
if (pathSegments[0] === 'nx-api') {
// TODO(v17): Remove this once vue is public or once this logic is fixed
if (pathSegments[1] === 'vue') {
return true;
}

const packageJsonPath = join(
workspaceRoot,
'packages',
Expand All @@ -119,6 +124,7 @@ const sitemapLinks = readSiteMapIndex(
const errors: Array<{ file: string; link: string }> = [];
for (let file in documentLinks) {
for (let link of documentLinks[file]) {
// TODO(@isaacplmann): This ignores errors which are links TO private packages. It allows links FROM public packages (public docs) TO private packages (404 links)
if (
!sitemapLinks.includes(['https://nx.dev', link].join('')) &&
!checkLinkIsForPrivatePackage(link)
Expand Down

1 comment on commit 57247e0

@vercel
Copy link

@vercel vercel bot commented on 57247e0 Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-five.vercel.app
nx.dev
nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app

Please sign in to comment.