-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(angular): inline loading @angular/compiler-cli in ng-packagr exec…
…utors (#20062)
- Loading branch information
1 parent
63f676c
commit c5a6107
Showing
3 changed files
with
33 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
packages/angular/src/executors/utilities/ng-compiler-cli.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
export function ngCompilerCli(): Promise< | ||
typeof import('@angular/compiler-cli') | ||
> { | ||
return loadEsmModule('@angular/compiler-cli'); | ||
} | ||
|
||
/** | ||
* Lazily compiled dynamic import loader function. | ||
*/ | ||
let load: (<T>(modulePath: string | URL) => Promise<T>) | undefined; | ||
|
||
/** | ||
* This uses a dynamic import to load a module which may be ESM. | ||
* CommonJS code can load ESM code via a dynamic import. Unfortunately, TypeScript | ||
* will currently, unconditionally downlevel dynamic import into a require call. | ||
* require calls cannot load ESM code and will result in a runtime error. To workaround | ||
* this, a Function constructor is used to prevent TypeScript from changing the dynamic import. | ||
* Once TypeScript provides support for keeping the dynamic import this workaround can | ||
* be dropped. | ||
* | ||
* @param modulePath The path of the module to load. | ||
* @returns A Promise that resolves to the dynamically imported module. | ||
*/ | ||
export function loadEsmModule<T>(modulePath: string | URL): Promise<T> { | ||
load ??= new Function('modulePath', `return import(modulePath);`) as Exclude< | ||
typeof load, | ||
undefined | ||
>; | ||
|
||
return load(modulePath); | ||
} |