Skip to content

Commit

Permalink
fix(nx): global cli warning false positives
Browse files Browse the repository at this point in the history
  • Loading branch information
vsavkin committed Jul 30, 2019
1 parent 790f174 commit d3dc2f4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
1 change: 0 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ Before you submit an issue, please search the issue tracker. An issue for your p
We want to fix all the issues as soon as possible, but before fixing a bug we need to reproduce and confirm it. Having a reproducible scenario gives us wealth of important information without going back and forth with you requiring additional information, such as:

- version of Nx used
- `workspace.json` or `angular.json` configuration
- `yarn.lock` or `package-lock.json`
- and most importantly - a use-case that fails

Expand Down
6 changes: 2 additions & 4 deletions packages/cli/bin/nx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ if (workspace) {
if (w) {
require(path.join(w.dir, 'node_modules', '@nrwl', 'cli', 'bin', 'nx.js'));
} else {
console.error(
`Error: The current directory isn't part of an Nx workspace.`
);
process.exit(1);
console.log(`The current directory isn't part of an Nx workspace.`);
process.exit(0);
}
}

0 comments on commit d3dc2f4

Please sign in to comment.