feat(react): allow setting react preset to production when using cust…

…om BABEL_ENV (#19148)
nrwl · Sep 13, 2023 · dc8b408 · dc8b408
1 parent 7975950
commit dc8b408
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/react/babel.ts b/packages/react/babel.ts
@@ -3,6 +3,7 @@
  */
 
 interface NxReactBabelOptions {
+  development?: boolean;
   runtime?: string;
   importSource?: string;
   useBuiltIns?: boolean | string;
@@ -51,10 +52,16 @@ module.exports = function (api: any, options: NxReactBabelOptions) {
   };
 };
 
-function getReactPresetOptions({ presetOptions, env }) {
+function getReactPresetOptions({
+  presetOptions,
+  env,
+}: {
+  env: string;
+  presetOptions: NxReactBabelOptions;
+}) {
   const reactPresetOptions: Record<string, string | boolean> = {
     runtime: presetOptions.runtime ?? 'automatic',
-    development: env !== 'production',
+    development: presetOptions.development ?? env !== 'production',
   };
 
   // JSX spread is transformed into object spread in `@babel/plugin-transform-react-jsx`

diff --git a/packages/web/src/executors/file-server/file-server.impl.ts b/packages/web/src/executors/file-server/file-server.impl.ts
@@ -70,7 +70,7 @@ function getBuildTargetOutputPath(options: Schema, context: ExecutorContext) {
 
   let buildOptions;
   try {
-    const target = parseTargetString(options.buildTarget, context.projectGraph);
+    const target = parseTargetString(options.buildTarget, context);
     buildOptions = readTargetOptions(target, context);
   } catch (e) {
     throw new Error(`Invalid buildTarget: ${options.buildTarget}`);