Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): improve core features and concepts #19014

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

juristr
Copy link
Member

@juristr juristr commented Sep 5, 2023

Wait with merging until this one is in: #19647
Then rebase to account for the new way of defining cacheableOperations.

This PR improves some of the core & concept docs and introduces a new "Tasks & Caching" recipe section. In particular

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 8:16pm

@juristr juristr force-pushed the docs-improve-core-features-concepts branch 2 times, most recently from ed02ade to ec4beb1 Compare September 5, 2023 21:37
@juristr juristr force-pushed the docs-improve-core-features-concepts branch from ec4beb1 to 21f0d0e Compare October 13, 2023 19:37
@juristr juristr force-pushed the docs-improve-core-features-concepts branch from b43787d to 85157f7 Compare October 18, 2023 19:05
@juristr juristr force-pushed the docs-improve-core-features-concepts branch 2 times, most recently from 4b0b048 to 913e42d Compare October 18, 2023 19:35
@juristr juristr force-pushed the docs-improve-core-features-concepts branch from 913e42d to 45f3245 Compare October 18, 2023 19:50
@juristr juristr force-pushed the docs-improve-core-features-concepts branch from 5558f17 to aeffe97 Compare October 18, 2023 21:31
@isaacplmann isaacplmann added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Oct 19, 2023
@juristr juristr force-pushed the docs-improve-core-features-concepts branch from aeffe97 to a2f926b Compare October 19, 2023 07:04
@juristr juristr marked this pull request as ready for review October 19, 2023 07:04
@juristr juristr requested review from a team as code owners October 19, 2023 07:04
@juristr juristr requested a review from vsavkin October 19, 2023 07:04
@juristr juristr removed the PR status: do not merge This will block a PR from being merged until this tag is removed. label Oct 19, 2023
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the content. A few recipes should be split into separate pages. And I made wording changes across all the pages.

docs/map.json Show resolved Hide resolved
docs/shared/core-features/run-tasks.md Show resolved Hide resolved
docs/shared/core-features/run-tasks.md Show resolved Hide resolved
docs/shared/core-features/run-tasks.md Show resolved Hide resolved
docs/shared/core-features/run-tasks.md Outdated Show resolved Hide resolved
docs/shared/recipes/running-tasks/customizing-inputs.md Outdated Show resolved Hide resolved
docs/shared/recipes/running-tasks/customizing-inputs.md Outdated Show resolved Hide resolved
docs/shared/recipes/running-tasks/customizing-inputs.md Outdated Show resolved Hide resolved
docs/shared/recipes/running-tasks/customizing-inputs.md Outdated Show resolved Hide resolved
docs/shared/recipes/running-tasks/customizing-inputs.md Outdated Show resolved Hide resolved
@juristr juristr force-pushed the docs-improve-core-features-concepts branch from a5749ef to f3be6c3 Compare October 19, 2023 20:10
@juristr juristr enabled auto-merge (rebase) October 19, 2023 20:12
@juristr juristr merged commit 15f558d into nrwl:master Oct 19, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants