-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): add 'git-tag' currentVersionResolver and conventional commits support #19267
feat(release): add 'git-tag' currentVersionResolver and conventional commits support #19267
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9017069. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
dcfb30b
to
f4627ec
Compare
5d2a145
to
a836c92
Compare
Setting to draft while we merge prerequisite PR and also figure out a couple of things |
e07c492
to
3b94c7e
Compare
3b94c7e
to
f788d9f
Compare
f788d9f
to
b91946c
Compare
fccfd31
to
3122420
Compare
62bfa95
to
98e1d7c
Compare
f3ae084
to
d99c278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Played with this locally today and found a couple things which we've patched and LGTM
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Adds
git-tag
as acurrentVersionResolver
option fornx release version
. This option will cause the current version for the release group to be taken from the most recent matching release tag, as configured withreleaseTagPattern
.Adds support for using conventional commits to determine the
specifier
for the version bump. In this case, thenx release version
command will look at git tags to determine which git ref to use as a base. Commits since the base will be parsed and any commits that touched files within any lib in the release group will be used to help determine the next version. Right now, onlyfix(...)
andfeat(...)
are recognized, but breaking changes are recognized (fix(...)!: ...
). If the previous version (from the git tag) is determined to be a prerelease, the bump type will always beprerelease
. The user will need to promote prereleases to regular releases manually by passing an explicit specifier, which will override that obtained from conventional commits standards.Uses
npm config get registry
to determine the default registry before falling back on https://registry.npmjs.orgMoves the specifier prompting into the version generator. This allows the current version determined in the generator to be used to determine the specifier when using conventional commits.