Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): rust task hasher #19617

Merged
merged 10 commits into from
Nov 21, 2023

Conversation

Cammisuli
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 7:14pm

@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 2 times, most recently from fc1af7d to 113a65b Compare October 19, 2023 13:04
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 2 times, most recently from be8ae01 to f575687 Compare October 30, 2023 13:46
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch from 61ec0ed to f602ff6 Compare October 30, 2023 20:35
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 4 times, most recently from d74cee5 to d83d05a Compare November 13, 2023 12:59
@Cammisuli Cammisuli marked this pull request as ready for review November 13, 2023 16:42
@Cammisuli Cammisuli requested review from a team, FrozenPandaz and vsavkin as code owners November 13, 2023 16:42
@Cammisuli Cammisuli requested a review from mandarini November 13, 2023 16:42
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 2 times, most recently from 0ad564d to 0e60633 Compare November 14, 2023 01:29
Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in js look good to me!

@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 4 times, most recently from dd0c88b to 92c1e38 Compare November 14, 2023 16:11
@Cammisuli Cammisuli requested a review from a team as a code owner November 14, 2023 16:11
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch from 92c1e38 to 959f0a5 Compare November 14, 2023 19:05
packages/nx/src/native/tasks/task_hasher.rs Outdated Show resolved Hide resolved
packages/nx/src/native/tasks/task_hasher.rs Outdated Show resolved Hide resolved
packages/nx/src/native/tasks/hashers/hash_runtime.rs Outdated Show resolved Hide resolved
packages/nx/src/native/tasks/task_hasher.rs Show resolved Hide resolved
packages/nx/src/native/transform-objects.ts Outdated Show resolved Hide resolved
packages/nx/src/native/tasks/task_hasher.rs Outdated Show resolved Hide resolved
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 2 times, most recently from 69c05dd to 9b9be96 Compare November 17, 2023 13:24
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 3 times, most recently from 3147f41 to d733353 Compare November 17, 2023 14:27
packages/nx/src/hasher/native-task-hasher-impl.ts Outdated Show resolved Hide resolved
packages/nx/src/hasher/native-task-hasher-impl.ts Outdated Show resolved Hide resolved
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch 2 times, most recently from e5f28cd to 7db14b7 Compare November 17, 2023 19:02
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch from 8b625c9 to 8855450 Compare November 17, 2023 21:20
@Cammisuli Cammisuli force-pushed the feature/nxc-9-task-hasher-in-rust branch from e545a18 to 8bcc7b3 Compare November 20, 2023 00:56
@FrozenPandaz FrozenPandaz merged commit 5d82a2a into nrwl:master Nov 21, 2023
6 checks passed
@Cammisuli Cammisuli deleted the feature/nxc-9-task-hasher-in-rust branch November 21, 2023 14:04
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants