docs(misc): Add Manage Library Versions recipe #19666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e088ef9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
isaacplmann
requested changes
Oct 17, 2023
There was a problem hiding this comment.
I really like the content, but this is a concept guide, not a recipe. It should be moved up into the (yet to be created) Module Federation section under concepts.
Also, we should make nice images in Figma that match our color scheme and work on both light and dark themes. (The images can be done in a separate PR though).
docs/shared/recipes/module-federation/manage-library-versions.md
Outdated
Show resolved
Hide resolved
docs/shared/recipes/module-federation/manage-library-versions.md
Outdated
Show resolved
Hide resolved
docs/shared/recipes/module-federation/manage-library-versions.md
Outdated
Show resolved
Hide resolved
ndcunningham
force-pushed
the
docs/manage-library-versions-mfe
branch
from
6e2a46d to
fbd5dc9
Compare
ndcunningham
force-pushed
the
docs/manage-library-versions-mfe
branch
2 times, most recently
from
c1aa521 to
ce5dd3d
Compare
ndcunningham
force-pushed
the
docs/manage-library-versions-mfe
branch
from
ce5dd3d to
dffebd0
Compare
ndcunningham
force-pushed
the
docs/manage-library-versions-mfe
branch
from
dffebd0 to
a4ce926
Compare
Coly010
approved these changes
Oct 19, 2023
docs/shared/guides/module-federation/manage-library-versions-with-module-federation.md
Outdated
Show resolved
Hide resolved
docs/shared/guides/module-federation/manage-library-versions-with-module-federation.md
Outdated
Show resolved
Hide resolved
isaacplmann
approved these changes
Oct 19, 2023
ndcunningham
force-pushed
the
docs/manage-library-versions-mfe
branch
from
a4ce926 to
e088ef9
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://nx-dev-git-fork-ndcunningham-docs-manage-library-ve-c0e82d-nrwl.vercel.app/recipes/module-federation/manage-library-versions
Current Behavior
No Recipe for Manging library versions with Module Federation
Expected Behavior
We should have a recipe, of how Nx manages library versions
Related Issue(s)
Fixes #