-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): support changelog customizations and project changelogs #19704
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 10d22f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
|
||
|
||
+ ## v999.9.9 | ||
+ ## 999.9.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was previously unintentional to have the v
prefix within the changelog contents, other tools don't do it, so this small change is a fix really
@@ -122,10 +123,10 @@ describe('nx release', () => { | |||
const changelogOutput = runCLI(`release changelog 999.9.9`); | |||
expect(changelogOutput).toMatchInlineSnapshot(` | |||
|
|||
> NX Generating a CHANGELOG.md entry for v999.9.9 | |||
> NX Generating an entry in CHANGELOG.md for v999.9.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched round the structure of the log, because now that the path is fully customizable it could end up being reasonably long (depending on the level of nesting within the tree) and for longer paths it reads better this new way round
|
||
|
||
|
||
> NX Previewing a Github release and an entry in {project-name}/CHANGELOG.md for {project-name}@v1000.0.0-next.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder that the {project-name}
here is normalized by the e2e snapshot serializer. I verified this produces the correct project name in real usage
878a450
to
6434f70
Compare
6434f70
to
e6c5912
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
release
config is not included in the JSON schemaAND
version
config at the root of release config to be shared across all groupscreateRelease
or the tag pattern to use for releases in configExpected Behavior
release
config is included in the JSON schemaAND
As of this PR, you can now:
renderOptions
(added oneincludeAuthors
option for now for our built in renderer)version
config at the root of release config to be shared across all groupscreateRelease
,file
andreleaseTagPattern
at both the root and group level of configNOTE: There are breaking changes to the supported CLI arguments for
nx release changelog
:--file
,--tag-version-prefix
and--create-release
no longer exist (replaced by config options)--interactive
is no longer a boolean, it takes in an enum string of eitherall
,workspace
orprojects
to control which projects you want to run interactively^ custom
releaseTagPattern
per group and project level github releases in action on this branch