fix(react): fix creating a react library with cwd #19721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4d3ce11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
feature/nxp-211-react-lib-generator-places-component-outside-of-project
branch
from
2af5866 to
4f15e12
Compare
mandarini
approved these changes
Oct 19, 2023
xiongemi
force-pushed
the
feature/nxp-211-react-lib-generator-places-component-outside-of-project
branch
from
4f15e12 to
5cb03a2
Compare
xiongemi
force-pushed
the
feature/nxp-211-react-lib-generator-places-component-outside-of-project
branch
from
5cb03a2 to
4d3ce11
Compare
jaysoo
approved these changes
Oct 19, 2023
jaysoo
reviewed
Oct 19, 2023
| @@ -171,9 +173,15 @@ export async function libraryGeneratorInternal(host: Tree, schema: Schema) { | |||
| } | |||
|
|
|||
| if (options.component) { | |||
| const relativeCwd = getRelativeCwd(); | |||
There was a problem hiding this comment.
I think we can just inline the logic of getRelativeCwd here if needed?
There was a problem hiding this comment.
Disregard, the other utils are also exported like getCwd.
FrozenPandaz
approved these changes
Oct 19, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #