-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rollup): use workspace rootDir while compiling TS files #19725
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 486cab9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
hi @ndcunningham, could you, please, advice how can I handle the CI failing issue? I'ts not clear for me what exactly failing and why |
Hello @kopach ! I looked into this thoroughly and that PR is not achieving the desired behaviour. What is described in the issue, is that if the I will be closing this PR, but thank you very much for contributing! Let me know if you have any concerns! |
Ok, sure @mandarini . No problem. It's just something which solves my issue (which has exact error output as described). I'm patching nx locally and it does the trick for me |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Fixes #11289
Tested this approach on real project using pnpm's patch mechanism