Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): use workspace rootDir while compiling TS files #19725

Closed
wants to merge 2 commits into from

Conversation

kopach
Copy link
Contributor

@kopach kopach commented Oct 19, 2023

Fixes #11289

Tested this approach on real project using pnpm's patch mechanism

@kopach kopach requested a review from a team as a code owner October 19, 2023 06:52
@kopach kopach requested a review from ndcunningham October 19, 2023 06:52
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Oct 24, 2023 2:43pm

@kopach
Copy link
Contributor Author

kopach commented Oct 20, 2023

hi @ndcunningham, could you, please, advice how can I handle the CI failing issue? I'ts not clear for me what exactly failing and why

@mandarini mandarini self-assigned this Oct 24, 2023
@mandarini
Copy link
Member

Hello @kopach ! I looked into this thoroughly and that PR is not achieving the desired behaviour. What is described in the issue, is that if the build target name is something else, then Nx does not identify the library as buildable, so this is the issue that should be addressed.

I will be closing this PR, but thank you very much for contributing! Let me know if you have any concerns!

@mandarini mandarini closed this Oct 25, 2023
@kopach
Copy link
Contributor Author

kopach commented Oct 25, 2023

Ok, sure @mandarini . No problem. It's just something which solves my issue (which has exact error output as described). I'm patching nx locally and it does the trick for me

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
@kopach kopach deleted the rollup branch October 31, 2023 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'rootDir' is expected to contain all source files. Bundle failed: test-icons
2 participants