fix(js): use workspace rootDir while compiling TS files

[kopach]

Fixes #11583

Tested this approach for some time already on real project using pnpm's patch mechanism

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Oct 20, 2023 3:31pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b28f70f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --target=e2e --base=1f0a54eda46d8aa3b8a11f29fb9f6f6e4c255997 --head=b28f70fe1ef9464e178df8af886e708092687267 --parallel=1
nx affected -t e2e-macos --parallel=1 --base=1f0a54eda46d8aa3b8a11f29fb9f6f6e4c255997 --head=b28f70fe1ef9464e178df8af886e708092687267

✅ Successfully ran 4 targets

• nx affected --targets=lint,test,build --base=1f0a54eda46d8aa3b8a11f29fb9f6f6e4c255997 --head=b28f70fe1ef9464e178df8af886e708092687267 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=1f0a54eda46d8aa3b8a11f29fb9f6f6e4c255997 --head=b28f70fe1ef9464e178df8af886e708092687267
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[kopach]

the fix is based on conversation from here: #11583
The only problem is that options.root (as suggested in comments) are always undefined. Tested and

tsConfig.options.rootDir = undefined;

Works as well. Decided to use '.' instead of undefined as similar approach is used in several other places in codebase

[kopach]

hi @FrozenPandaz, could you, please, advice how can I handle the CI failing issue? I'ts not clear for me what exactly failing and why

[mandarini]

@leosvelperez I am asking for your review, because I think you were the one working on the "file is not under rootDir" issues.

[leosvelperez]

hey @kopach! Thanks for taking the time to contribute, and apologies for the delay in reviewing it.

I'm going to close this since the current implementation is working as expected. All projects are built with the rootDir set to the project root or to what the user provides in the @nx/js:tsc executor options. The linked issue occurs due to a manual misconfiguration. I closed that issue by explaining this and how to solve it: #11583 (comment).

Other issues could result in the same error, but they are also solved differently and without the need to change the implementation.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.