chore(repo): update post install script to manually check for rust version less than 1.70 #19739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cammisuli
requested review from
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Cammisuli
force-pushed
the
update_post_install_script
branch
2 times, most recently
from
f1619a7 to
5e82023
Compare
AgentEnder
reviewed
Oct 19, 2023
scripts/preinstall.js
Outdated
Comment on lines
26
to
30
| const [major, minor, patch] = rustVersion.toString().split(' ')[1].split('.'); | ||
| if (+major < 1 || (+major === 1 && +minor < 70)) { | ||
| console.log(`Found ${rustVersion}`); | ||
| console.error( | ||
| 'Please make sure that your installed Rust version is greater than v1.70. You can update your installed Rust version with `rustup update`' | ||
| ); |
There was a problem hiding this comment.
Can we use the semver utility to check if the version is high enough? This isn't a super important area of the codebase but it'd be cleaner
…rsion less than 1.70
Cammisuli
force-pushed
the
update_post_install_script
branch
from
5e82023 to
f8573e3
Compare
AgentEnder
approved these changes
Oct 19, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Current repo rust code is using features that were stabilized in 1.70, and causes errors when the installed rust version is less than 1.70
Expected Behavior
Checks are done to make sure that people are using the proper version of rust
Related Issue(s)
Fixes #