feat(misc): remove usages of @nx/cypress:cypress-project internally #19766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 22f9ccb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
aa55e67 to
334bd04
Compare
mandarini
reviewed
Oct 23, 2023
mandarini
approved these changes
Oct 23, 2023
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
334bd04 to
2f5adb2
Compare
jaysoo
commented
Oct 23, 2023
packages/angular/src/generators/application/__snapshots__/application.spec.ts.snap
Show resolved
Hide resolved
AgentEnder
approved these changes
Oct 23, 2023
leosvelperez
approved these changes
Oct 23, 2023
|
PR updating the Angular e2e migrator: #19816. |
leosvelperez
requested changes
Oct 24, 2023
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
2f5adb2 to
4502206
Compare
leosvelperez
approved these changes
Oct 24, 2023
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
4502206 to
2603b93
Compare
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
2603b93 to
e471dd9
Compare
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
e471dd9 to
76de8e4
Compare
Replace with call to `@nx/cypress:configuration`. The deprecated generator will be removed in Nx 18.
jaysoo
force-pushed
the
feat/remove-deprecated-cypress-generator-internally
branch
from
76de8e4 to
22f9ccb
Compare
jaysoo
deleted the
feat/remove-deprecated-cypress-generator-internally
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with call to
@nx/cypress:configuration, consistent with how we setup Playwright projects for apps. The deprecated generator will be removed in Nx 18.Changes
@nx/cypress:cypress-projectgenerator has been replaced withaddProjectConfiguration+@nx/cypress:configuration@nx/storybook:cypress-projectgenerator updated to supportprojectNameAndRootFormat-- this was missed previouslytsconfig.jsonfile for the e2e project has a differentincludeconfig. Previously, we scoped tosrc/**/*.ts, but now it is**/*.ts, and we also include JSX files for React/Vue.Follow-up
@nx/cypress:configurationgenerator does not supportas-providedpaths, so we need a follow-up PR to address this issue.