Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devkit): mark ExecutorContext props required #19803

Closed
wants to merge 2 commits into from

Conversation

edbzn
Copy link
Contributor

@edbzn edbzn commented Oct 23, 2023

Current Behavior

Properties nxJsonConfiguration, projectGraph, projectsConfigurations, and workspace are optional in the ExecutorContext interface.

Expected Behavior

Mark these properties as required.

Related Issue(s)

N/A

@edbzn edbzn requested review from a team as code owners October 23, 2023 18:37
@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 8:36am

@edbzn edbzn requested a review from leosvelperez October 23, 2023 18:37
@edbzn edbzn force-pushed the feat-executor-context-props branch from 0c467e8 to 491fcb3 Compare October 24, 2023 08:35
@edbzn edbzn requested a review from a team as a code owner October 24, 2023 08:35
@edbzn edbzn closed this Feb 10, 2024
@edbzn edbzn deleted the feat-executor-context-props branch February 10, 2024 12:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant