Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): sort all workspace files after combining #19806

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

Cammisuli
Copy link
Member

Current Behavior

Collected workspace file inputs are not sorted before hashing

Expected Behavior

Workspace file inputs are now sorted before combining the hashes

Related Issue(s)

Fixes #19275

@Cammisuli Cammisuli requested a review from a team as a code owner October 23, 2023 19:34
@Cammisuli Cammisuli requested a review from AgentEnder October 23, 2023 19:34
@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2023 1:25pm

@Cammisuli Cammisuli changed the title fix(core): sort workspace file set hashes fix(core): sort all workspace file after combining Oct 24, 2023
@Cammisuli Cammisuli changed the title fix(core): sort all workspace file after combining fix(core): sort all workspace files after combining Oct 24, 2023
@Cammisuli Cammisuli enabled auto-merge (squash) October 24, 2023 14:16
@Cammisuli Cammisuli merged commit f5eeb0a into nrwl:master Oct 24, 2023
2 checks passed
@Cammisuli Cammisuli deleted the fix/19275 branch October 24, 2023 14:21
FrozenPandaz pushed a commit that referenced this pull request Oct 25, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NX computed hash used for cache is different on every run when no changes are introduced
2 participants