fix(core): allow for non-js libs to be moved without errors or the creation of any unneeded tsconfig files

[KerickHowlett]

Current Behavior

I have a project that is utilizing the @nx-go/nx-go extension that's used for supporting Go applications.

When I attempt to use the @nx/workspace:move generator to move a Go library, it'll produce an error. (Please refer to the Failure Logs section for said error.)

Sadly, there isn't a consistent means to get the bun to start showing up, but once it does, the issue will persist throughout the workspace's life cycle.

I was able to trace this to the compiled Javascript files within Nx's installed project files under the node_modules directory, which is where I found a workaround. That being to have the secondaryEntryPointImportPaths variable (located within the updateImports function) set with an empty array on the same line it's declared.

However, this will produce a tsconfig.base.json file at the root of the workspace with the text undefined contained within it and with no actual JSON to speak of.

Expected Behavior

I have a project that is utilizing the @nx-go/nx-go extension that's used for supporting Go applications.

The @nx/workspace:move schematic generator should be able to move libraries based in Go and other programming languages without any errors popping up.

It should also do it without generating an empty tsconfig.base.json file if one didn't exist previously. This tends to be the case when there is no Typescript to speak of within the Nx workspace. For example, an Nx workspace initiated with the @nx-go/nx-go preset.

Related Issue(s)

• #28349

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Dec 18, 2024 6:05pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 756614e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

🟥 Failed Commands
nx affected --targets=lint,test,build,e2e,e2e-ci --base=cc1441170abb54b354c8dada3ecd5e820d3836d6 --head=756614e0885edce753a7d16fb45ed4548fcd338c --parallel=3

✅ Successfully ran 5 targets

• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx-cloud conformance:check
• nx-cloud record -- nx format:check --base=cc1441170abb54b354c8dada3ecd5e820d3836d6 --head=756614e0885edce753a7d16fb45ed4548fcd338c
• nx-cloud record -- nx sync:check
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[isaacplmann]

Don't create a new scope. Use core for changes to workspace. Someone else will review the actual code changes

[KerickHowlett]

Don't create a new scope. Use core for changes to workspace. Someone else will review the actual code changes

Oh! That's my bad. I'll undo the commitizen changes and amend my commit messages.

[isaacplmann]

@jaysoo can you take a look at this PR?

[jaysoo]

I think moving writeJson(...) into the if (tsConfig) is enough to fix the issue.

Updating getRootTsConfigPathInTree is fine since it's only used here and in the remove generator. But we should also change the check to tree.exists(tsConfigPath) to account for null.

[KerickHowlett]

That thought did cross my mind, but I was worried about false positives. I'll remove the second clause all the same, though. I'll also go ahead and take a look at tree.exists(tsConfigPath) so that it'll account for null.

I also believe I can greatly clean up the code quite a bit, too, so that it scales far better. I just wanted to hold off on it in favor of getting these essential changes merged quickly first before with as few changes as possible.

[KerickHowlett]

I looked into updating tree.exists(filePath) to change its argument typing to string | null directly without just adding on another if-operator clause.

From what I can tell, it would require touching 3 additional files (with starting line numbers):

1. packages/devkit/src/utils/invoke-nx-generator.ts:L131
2. packages/nx/src/generators/tree.ts:L62
3. e2e/utils/file-utils.ts:L111

The changes seem fairly straight forward, but since this effects a critical Nx component, I figured we could save it for a second PR that I can submit right after this one gets approved. If anything else, just to keep the PRs better focused.

With that said, I applied the necessary changes locally on my machine.

[nx-cloud]

Your CI Pipeline Execution ↗ for commit f094547 is in progress ⏳

Command	Status	Duration	Result
nx affected --targets=lint,test,build,e2e,e2e-c...	❌ Failed	39m 23s	View ↗
nx run-many -t check-imports check-commit check...	✅ Succeeded	1m 5s	View ↗
nx-cloud record -- nx-cloud conformance:check	✅ Succeeded	<1s	View ↗
nx-cloud record -- nx format:check --base=d05f3...	✅ Succeeded	29s	View ↗
nx-cloud record -- nx sync:check	✅ Succeeded	28s	View ↗
nx documentation --no-dte	✅ Succeeded	46s	View ↗

---

☁️ Nx Cloud last updated this comment at 2024-12-18 18:43:13 UTC