chore(repo): add conformance rule for our package.json files #29078
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| "@jest/reporters": "^29.4.1", | ||
| "@jest/test-result": "^29.4.1", | ||
| "@jest/types": "^29.4.1", | ||
| "@jest/reporters": "29.7.0", |
There was a problem hiding this comment.
Our jest packages weren't aligned for some reason
| @@ -60,5 +60,8 @@ | |||
| }, | |||
| "nx-migrations": { | |||
| "migrations": "./migrations.json" | |||
| }, | |||
| "publishConfig": { | |||
There was a problem hiding this comment.
Found by the new rule!
There was a problem hiding this comment.
I thought we needed this for provenance... how does rspack have provenance without this?
There was a problem hiding this comment.
It's not for provenance, it's needed because the default access for new scoped package is restricted and so the first time we publish a new package we need this explicit config. Technically after that point we no longer need it anymore, but it doesn't do any harm, just makes its state explicit, and so having this be a rule for all package.json files means we won't run into any issues when new packages are added in future.
JamesHenry
force-pushed
the
package-json-conformance-rule
branch
from
b9be66d to
6bf9063
Compare
|
Your CI Pipeline Execution ↗ for commit 0321794 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
JamesHenry
requested review from
a team,
vsavkin,
AgentEnder and
jaysoo
as code owners
JamesHenry
force-pushed
the
package-json-conformance-rule
branch
from
059d2f8 to
0321794
Compare
No description provided.