feat(rsbuild): add react and vue support for app generation #29349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your CI Pipeline Execution ↗ for commit 32bc425 ⏳ is in progress.
Last updated at 2024-12-13 17:45:27UTC Sent with 💌 from NxCloud. |
|
Your CI Pipeline Execution ↗ for commit 4638f8b is in progress ⏳
☁️ Nx Cloud last updated this comment at |
Coly010
force-pushed
the
rsbuild/react-support
branch
from
bfafefd to
92a9766
Compare
Coly010
force-pushed
the
rsbuild/react-support
branch
from
92a9766 to
9fc8ab5
Compare
Coly010
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
Coly010
changed the title
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
jaysoo
reviewed
Dec 17, 2024
Coly010
force-pushed
the
rsbuild/react-support
branch
from
4b4c029 to
b9a2a29
Compare
Coly010
force-pushed
the
rsbuild/react-support
branch
from
23b6a60 to
8bd92a0
Compare
Coly010
force-pushed
the
rsbuild/react-support
branch
from
8bd92a0 to
4638f8b
Compare
Coly010
commented
Dec 18, 2024
| ); | ||
|
|
||
| // TODO: enable this when tests are passing again. | ||
| // Colum confirmed locally that the generated config and the playwright tests are working. |
There was a problem hiding this comment.
The other vue e2e test also has the runE2e block commented out.
We should investigate why it doesn't like CI later
jaysoo
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We do not have a generator that can scaffold a react or vue app using rsbuild.
Expected Behavior
Update the react application generator to support a bundler option of rsbuild
Update the vue application generator to support a bundler option of rsbuild