Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): create conformance rule recipe #29406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

isaacplmann
Copy link
Collaborator

@isaacplmann isaacplmann commented Dec 18, 2024

Blocked until the create-rule generator is merged and released

@isaacplmann isaacplmann requested review from a team as code owners December 18, 2024 20:00
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:26pm

@isaacplmann isaacplmann added the PR status: do not merge This will block a PR from being merged until this tag is removed. label Dec 18, 2024
@isaacplmann isaacplmann self-assigned this Dec 18, 2024
@isaacplmann isaacplmann requested review from JamesHenry and removed request for leosvelperez December 18, 2024 20:00
Copy link

nx-cloud bot commented Dec 18, 2024

Your CI Pipeline Execution ↗ for commit 1df46cc is in progress ⏳

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 42s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m View ↗
nx-cloud record -- nx format:check --base=0720f... ✅ Succeeded 23s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx documentation --no-dte ✅ Succeeded 44s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-18 20:27:18 UTC

} from '@nx/powerpack-conformance';

export default createConformanceRule({
name: 'ensure-owners',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is exposed via the conformance package already, so we shouldn't encourage folks to reimplement it directly without clarifying it's just for illustrative purposes

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the publish conformance rule guide to not repeat guidance on how to create and organize the rules, only add the publishing to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR status: do not merge This will block a PR from being merged until this tag is removed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants