-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(js): handle resolution from within node_module in the sync generator #29412
fix(js): handle resolution from within node_module in the sync generator #29412
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
View your CI Pipeline Execution ↗ for commit 154e3ac.
☁️ Nx Cloud last updated this comment at |
932a757
to
c5160da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The changes look good to me. Let's just change it to use tree.root
instead of importing workspaceRoot
.
Thanks @leosvelperez ! I didn't think about using the tree.root, changes are applied! ✔️ |
5a8b0df
to
154e3ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…tor (#29412) closed #29411 <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> The resolve function from ts.System returning the full path, and so including the workspaceRoot that is also append by the FsTree ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Resolution within node_modules are correctly followed ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29411
closed #29411
Current Behavior
The resolve function from ts.System returning the full path, and so including the workspaceRoot that is also append by the FsTree
Expected Behavior
Resolution within node_modules are correctly followed
Related Issue(s)
Fixes #29411