Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws: allow filtering notification by parameters #3689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

rpcsrv/tests: simplify tests with parsed test contract hash

97bd73b
Select commit
Loading
Failed to load commit list.
Open

ws: allow filtering notification by parameters #3689

rpcsrv/tests: simplify tests with parsed test contract hash
97bd73b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 25, 2024 in 0s

83.01% (-0.04%) compared to ff15e39

View this Pull Request on Codecov

83.01% (-0.04%) compared to ff15e39

Details

Codecov Report

Attention: Patch coverage is 60.37736% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (ff15e39) to head (97bd73b).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/neorpc/filters.go 50.00% 13 Missing and 5 partials ⚠️
pkg/neorpc/rpcevent/filter.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3689      +/-   ##
==========================================
- Coverage   83.04%   83.01%   -0.04%     
==========================================
  Files         335      335              
  Lines       46719    46782      +63     
==========================================
+ Hits        38800    38834      +34     
- Misses       6327     6350      +23     
- Partials     1592     1598       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.