Skip to content

Commit

Permalink
ir/reputation: Drop no longer relevant FIXMEs
Browse files Browse the repository at this point in the history
They have already been resolved earlier.

Closes #1147.

Signed-off-by: Leonard Lyubich <[email protected]>
  • Loading branch information
cthulhu-rider committed Sep 7, 2023
1 parent 589ec59 commit c1d3b03
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion pkg/innerring/processors/reputation/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ func (rp *Processor) handlePutReputation(ev event.Event) {
put := ev.(reputationEvent.Put)
peerID := put.PeerID()

// FIXME: #1147 do not use `ToV2` method outside neofs-api-go library
rp.log.Info("notification",
zap.String("type", "reputation put"),
zap.String("peer_id", hex.EncodeToString(peerID.PublicKey())))
Expand Down
2 changes: 0 additions & 2 deletions pkg/innerring/processors/reputation/process_put.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ func (rp *Processor) checkManagers(e uint64, mng apireputation.PeerID, peer apir
}

for _, m := range mm {
// FIXME: #1147 do not use `ToV2` method outside neofs-api-go library
if bytes.Equal(mng.PublicKey(), m.PublicKey()) {
return nil
}
Expand All @@ -81,7 +80,6 @@ func (rp *Processor) approvePutReputation(e *reputationEvent.Put) {
err = rp.reputationWrp.Morph().NotarySignAndInvokeTX(nr.MainTransaction)

if err != nil {
// FIXME: #1147 do not use `ToV2` method outside neofs-api-go library
rp.log.Warn("can't send approval tx for reputation value",
zap.String("peer_id", hex.EncodeToString(id.PublicKey())),
zap.String("error", err.Error()))
Expand Down

0 comments on commit c1d3b03

Please sign in to comment.