blobovnicza: Fix write error at zero depth #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2454 +/- ##
==========================================
+ Coverage 29.41% 29.44% +0.03%
==========================================
Files 399 399
Lines 30346 30385 +39
==========================================
+ Hits 8925 8946 +21
- Misses 20680 20696 +16
- Partials 741 743 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Jul 25, 2023
carpawell
reviewed
Jul 25, 2023
Previously, blobovnicza tree with depth=0 (i.e. group of DBs without subdirectories) failed to write any object. There was a mistake in code which worked incorrectly for depth=0 particular case. Fix `iterateDeepest` method iterating over paths to DBs as if they were directories. From now it passes current directory only. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/blobovnicza-tree-zero-depth
branch
from
2d44249
to
be4bbfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
well, we're willing to get rid of complex blobovnicza tree. But this fix is simple, and it's needed to benchmark flat list of DBs within #2453