add function and method to electric_field to compute Stokes parameters #749
+147
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fschlueter
reviewed
Nov 19, 2024
fschlueter
previously approved these changes
Nov 21, 2024
cg-laser
previously approved these changes
Nov 21, 2024
|
@MijnheerD My changes got approved by Felix and Christian, and I'm happy to approve your changes which don't change the functionality but just speed things up a lot. So as far as I'm concerned you can approve this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function to
trace_utilitiesand a method to theelectric_fieldclass to compute Stokes parameters.