Do not use refractive index of ice at LOFAR/Auger #757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
NuRadioReco.utilities.ice
ice 'model' is still used internally by some modules, including the voltageToEfieldConverter which is used also by LOFAR. This leads to unwanted behaviour for antennas with z-coordinates < 0.In future, this module should probably be deprecated because it also doesn't do the right thing for deep in-ice antennas (or any ice where the assumption that n_ice=1.3 is wrong). But this would be slightly more work, depending on how we want to implement it (e.g. should air-to-ice raytracing be included).