Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use refractive index of ice at LOFAR/Auger #757

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sjoerd-bouma
Copy link
Collaborator

The old NuRadioReco.utilities.ice ice 'model' is still used internally by some modules, including the voltageToEfieldConverter which is used also by LOFAR. This leads to unwanted behaviour for antennas with z-coordinates < 0.

In future, this module should probably be deprecated because it also doesn't do the right thing for deep in-ice antennas (or any ice where the assumption that n_ice=1.3 is wrong). But this would be slightly more work, depending on how we want to implement it (e.g. should air-to-ice raytracing be included).

Copy link
Collaborator

@cg-laser cg-laser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should probably deprecate this module. The fix for now looks good.

And yes, the efieldToVoltageConverter only works for local antennas. Two assumptions need to be fulfilled

  • straight line propagation. i.e. constant index-of-refraction
  • same efield in all antennas

so this only works for very compact antenna clusters or the dual-polarizided antennas used in air-shower arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants