Lofar/add pipeline plots #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippLaub
reviewed
Nov 21, 2024
| class pipelineVisualizer: | ||
| """ | ||
| Creates debug plots from the LOFAR pipeline - | ||
| This is the pipelineVisualizerTM for LOFAR. |
There was a problem hiding this comment.
*glorious pipelineVisualizerTM :)
There was a problem hiding this comment.
thank you, Philipp
PhilippLaub
reviewed
Nov 21, 2024
| # plot absolute station positions | ||
| if station.get_parameter(stationParameters.triggered): | ||
| station_pos = detector.get_absolute_position(station.get_id()) | ||
| ax.scatter(station_pos[0], station_pos[1], color=cmap(norm(i)), s=20, label=f'Station CS{station.get_id():03d}') |
There was a problem hiding this comment.
maybe a different marker would be good to differentiate between station positions and antenna positions later (square or star?)
There was a problem hiding this comment.
good point! (pun intended)
|
I merged these changes locally, so I will close this PR. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module modules/LOFAR/pipelineVisualization_LOFAR.py creates some nice plots at the end of the pipeline, i.e. the polarisation of antennas, the reconstructed arrival directions for all stations and also the fluence/timing/direction plot. Unless otherwise specified, it saves the plots in the current working directory. Furthermore it raises warnings if the polarisations in single antennas are very off or if the event time was before the outer station clocks were synced with the core station clocks.