Allow negative delays in trace_utilities.delay #768
+18
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not finished yet and will break the tests. We have to take a few decisions here. Currently I am always cropping the traces after delaying to remove the now unphysical signals at the beginning or end. However, in case of a positive delay this will change the trace start time (as it did before). This is now calculated in function. If we want to keep that we have to change the code where this function is used. I also changed the calculation of the number of samples to crop. We might need to check if that calculation agrees now with calculations outside of this function. And finally, why do we have the argument
delayed_samples
I would remove it.