LANL1D model addition #379
Conversation
Adding first rendition of LANL1D function
Un-commenting the Ye_wind parameter
Commenting out KNtheta parameter in LANL1D
Adding parameters for LANL1D
Creation of LANL1d prior file
edited vej_dyn to the proper numbers
update get_knprops_from_LANLfilename to account for masses in filenames that aren't followed by another letter
Adjusting the timeshift
changing from log_10_mej_dyn to mej_dyn
Changed from log_10_mej_dyn to mej_dyn in LANL1D
Changing timeshift
updating log10_mej_dyn
updating log10_mej_dyn
Setting timeshift=0 and luminosity_distance=40.7 to properly reflect the files
|
@mreuter01 I am assuming this model uses SVDLightCurveModel, if so, can you point to the model files as well? |
|
@mreuter01 also, any reference paper for this model? |
Reverting file back to its previous state
What do you mean by this Sahil? @mreuter01 remove the unnecessary commented lines please |
Removed unnecessary commenting from LANL1D
@sahiljhawar fixed.
@bking-astro fixed. |
|
@bking-astro SVD files (h5 or pkl files). If such files exists, those needs to be added to the gitlab repo |
They should be added now. Let me know if there's something else I need to do. |
|
LGTM |
|
@bking-astro feel free to merge if you are okay with this |
This fork is the repository I built my new model on. It runs successfully with the rest of NMMA and does not interfere with the function of other people's models and/or other functions within the code.