New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace validation and external markers package #79

Merged

lander2k2 merged 2 commits into nukleros:main from scottd018:feat-markers-package

Jul 31, 2024

Contributor

scottd018 commented Jul 23, 2024

This PR addresses the following:

Moves markers package from internal to the externally-provided package (same code, standalone repo) > https://github.com/nukleros/markers > Fixes Move markers package to its own project and import it #67
Adds validation for missing replace text > return an error and notify user > Fixes feat: replace text with missing replace results in hard-coded values #33

scottd018 added 2 commits

July 23, 2024 08:58


          chore: Fixes nukleros#67, import external markers package

a3d19a0

Signed-off-by: Dustin Scott <[email protected]>


          fix: Fixes nukleros#33, add validation for replace text

0ad47a4

Signed-off-by: Dustin Scott <[email protected]>

lander2k2 approved these changes

View reviewed changes

lander2k2 merged commit f623317 into nukleros:main

12 of 13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet