Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the discrepancy in password guesses between zxcvbn and zxcvbn4j #151

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: fix the discrepancy in password guesses between zxcvbn and zxcvbn4j #151

merged 1 commit into from
Aug 21, 2023

Conversation

vvatanabe
Copy link
Member

@vvatanabe vvatanabe commented Aug 21, 2023 •
edited
Loading

Describe the change

Fix the discrepancy in password guesses between zxcvbn and zxcvbn4j.

Describe your solution

  • The constant REFERENCE_YEAR was changed to get the current year.
  • Fixed the logic of possibleYearSplits in DateMatcher.

Tests

  • Add DateGuessTest to ScoringTest.
  • Add date pattern to MatchingTest.

Additional context
Issue: #151

@vvatanabe vvatanabe force-pushed the fix-the-discrepancy-in-password-guesses-between-zxcvbn-and-zxcvbn4j branch from da2416c to 44dda11 Compare August 21, 2023 05:36
@coveralls
Copy link

Coverage Status

coverage: 92.662% (-0.02%) from 92.68% when pulling 44dda11 on fix-the-discrepancy-in-password-guesses-between-zxcvbn-and-zxcvbn4j into a213a44 on main.

@vvatanabe vvatanabe merged commit 1b31a17 into main Aug 21, 2023
1 check passed
@vvatanabe vvatanabe deleted the fix-the-discrepancy-in-password-guesses-between-zxcvbn-and-zxcvbn4j branch August 21, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvatanabe @coveralls