Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix sonarcloud reliability #159

Merged
merged 4 commits into from
Aug 28, 2023
Merged

fix: Fix sonarcloud reliability #159

merged 4 commits into from
Aug 28, 2023

Conversation

vvatanabe
Copy link
Member

Fix sonarcloud reliability:

  • Use another way to initialize this instance in L33tMatcher.
  • Cast one of the operands of this subtraction operation to a double in Scoring.
  • Use BigDecimal.valueOf instead in TimeEstimates.
  • Cast one of the operands of this multiplication operation to a double in DictionaryGuess.

@vvatanabe vvatanabe merged commit 3d29dbd into main Aug 28, 2023
1 check passed
@coveralls
Copy link

Coverage Status

coverage: 92.926% (-0.004%) from 92.93% when pulling c1a1331 on fix-sonarcloud-reliability into f4b34cf on main.

@vvatanabe vvatanabe deleted the fix-sonarcloud-reliability branch August 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vvatanabe @coveralls