Fix startWith, endWith, append, and prepend methods

nullobject · Jan 26, 2019 · 4aad28c · 4aad28c
1 parent a4f3d7c
commit 4aad28c
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## Unreleased
+
+* Fix issue with array arguments passed to `startWith`, `endWith`, `append`, and `prepend` methods
+
 ## 3.0.1 (2019-01-26)
 
 * Add `Signal#startWith` and `Signal#endWith` methods

diff --git a/packages/bulb/package-lock.json b/packages/bulb/package-lock.json
diff --git a/packages/bulb/src/Signal.js b/packages/bulb/src/Signal.js
@@ -482,7 +482,7 @@ export default class Signal {
       as = as[0]
     }
 
-    return concat(this, Signal.fromArray(as))
+    return concat([this, Signal.fromArray(as)])
   }
 
   /**
@@ -801,7 +801,7 @@ export default class Signal {
    * t.subscribe(console.log) // 1, 2, 3, 4
    */
   endWith (a) {
-    return concat(this, Signal.of(a))
+    return concat([this, Signal.of(a)])
   }
 
   /**
@@ -965,7 +965,7 @@ export default class Signal {
       as = as[0]
     }
 
-    return concat(Signal.fromArray(as), this)
+    return concat([Signal.fromArray(as), this])
   }
 
   /**
@@ -1044,7 +1044,7 @@ export default class Signal {
    * t.subscribe(console.log) // 0, 1, 2, 3
    */
   startWith (a) {
-    return concat(Signal.of(a), this)
+    return concat([Signal.of(a), this])
   }
 
   /**

diff --git a/packages/bulb/src/Signal.test.js b/packages/bulb/src/Signal.test.js
@@ -257,13 +257,13 @@ describe('Signal', () => {
 
     it('handles an array', () => {
       s.append([1, 2, 3])
-      expect(concat).toHaveBeenCalledWith(s, t)
+      expect(concat).toHaveBeenCalledWith([s, t])
       expect(spy).toHaveBeenCalledWith([1, 2, 3])
     })
 
     it('handles multiple arguments', () => {
       s.append(1, 2, 3)
-      expect(concat).toHaveBeenCalledWith(s, t)
+      expect(concat).toHaveBeenCalledWith([s, t])
       expect(spy).toHaveBeenCalledWith([1, 2, 3])
     })
   })
@@ -345,7 +345,7 @@ describe('Signal', () => {
     it('appends the given value', () => {
       s.endWith(1)
       expect(spy).toHaveBeenCalledWith(1)
-      expect(concat).toHaveBeenCalledWith(s, t)
+      expect(concat).toHaveBeenCalledWith([s, t])
     })
   })
 
@@ -404,13 +404,13 @@ describe('Signal', () => {
     it('handles an array', () => {
       s.prepend([1, 2, 3])
       expect(spy).toHaveBeenCalledWith([1, 2, 3])
-      expect(concat).toHaveBeenCalledWith(t, s)
+      expect(concat).toHaveBeenCalledWith([t, s])
     })
 
     it('handles multiple arguments', () => {
       s.prepend(1, 2, 3)
       expect(spy).toHaveBeenCalledWith([1, 2, 3])
-      expect(concat).toHaveBeenCalledWith(t, s)
+      expect(concat).toHaveBeenCalledWith([t, s])
     })
   })
 
@@ -430,7 +430,7 @@ describe('Signal', () => {
     it('prepends the given value', () => {
       s.startWith(1)
       expect(spy).toHaveBeenCalledWith(1)
-      expect(concat).toHaveBeenCalledWith(t, s)
+      expect(concat).toHaveBeenCalledWith([t, s])
     })
   })