review comments

Signed-off-by: Yashash H L <[email protected]>

pkg/reducer/interface.go

@@ -29,7 +29,7 @@ type ReducerCreator interface {
 	Create() Reducer
 }
 
-// simpleReducerCreator is a implementation of ReducerCreator, which creates a Reducer for the given function.
+// simpleReducerCreator is an implementation of ReducerCreator, which creates a Reducer for the given function.
 type simpleReducerCreator struct {
 	f func(context.Context, []string, <-chan Datum, Metadata) Messages
 }
@@ -39,8 +39,8 @@ func (s *simpleReducerCreator) Create() Reducer {
 	return reducerFn(s.f)
 }
 
-// SimpleReducerCreator creates a simple ReducerCreator for the given reduce function.
-func SimpleReducerCreator(f func(context.Context, []string, <-chan Datum, Metadata) Messages) ReducerCreator {
+// SimpleCreatorWithReduceFn creates a simple ReducerCreator for the given reduce function.
+func SimpleCreatorWithReduceFn(f func(context.Context, []string, <-chan Datum, Metadata) Messages) ReducerCreator {
 	return &simpleReducerCreator{f: f}
 }
 

pkg/reducer/server_test.go

@@ -33,6 +33,6 @@ func TestReduceServer_Start(t *testing.T) {
 	// note: using actual uds connection
 	ctx, cancel := context.WithTimeout(context.Background(), 6*time.Second)
 	defer cancel()
-	err := NewServer(SimpleReducerCreator(rfn), WithSockAddr(socketFile.Name()), WithServerInfoFilePath(serverInfoFile.Name())).Start(ctx)
+	err := NewServer(SimpleCreatorWithReduceFn(rfn), WithSockAddr(socketFile.Name()), WithServerInfoFilePath(serverInfoFile.Name())).Start(ctx)
 	assert.NoError(t, err)
 }

pkg/reducer/service_test.go

@@ -249,7 +249,7 @@ func TestService_ReduceFn(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			fs := &Service{
-				CreateReduceHandler: SimpleReducerCreator(tt.handler),
+				CreateReduceHandler: SimpleCreatorWithReduceFn(tt.handler),
 			}
 			// here's a trick for testing:
 			// because we are not using gRPC, we directly set a new incoming ctx