chore: add best practices section in docs #2184
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2184 +/- ##
==========================================
- Coverage 63.93% 63.75% -0.19%
==========================================
Files 334 334
Lines 40676 40676
==========================================
- Hits 26006 25932 -74
- Misses 13609 13687 +78
+ Partials 1061 1057 -4 ☔ View full report in Codecov by Sentry. |
whynowy
reviewed
Oct 24, 2024
mkdocs.yml
Outdated
| @@ -127,6 +127,7 @@ nav: | |||
| - operations/metrics/metrics.md | |||
| - operations/grafana.md | |||
| - Security: operations/security.md | |||
| - Best Practices: operations/best-practices.md | |||
There was a problem hiding this comment.
Best Practices as a folder, and different pages for different topics?
Signed-off-by: Sidhant Kohli <[email protected]>
KeranYang
approved these changes
Nov 1, 2024
|
@whynowy Are you good to merge? |
whynowy
reviewed
Nov 4, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
whynowy
approved these changes
Nov 5, 2024
vigith
requested changes
Nov 5, 2024
@kohlisid are you looking into this? |
|
@vigith Yes! |
|
can you please link the issue if you have any? |
|
i want to close this one out. |
|
We can use this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.