Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: counter metrics visualizer for pipeline #2238

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion config/advanced-install/namespaced-numaflow-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -186,6 +186,32 @@ data:
# required: false
# - name: mono-vertex
# #expr: optional
- name: pipeline_counter_metrics
object: vertex
title: Rate of Change of metrics
description: This pattern is to calculate rate of change of counter metrics
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: forwarder_data_read_total
required_filters:
- namespace
- pipeline
- vertex
dimensions:
- name: vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down
28 changes: 27 additions & 1 deletion config/advanced-install/numaflow-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -193,6 +193,32 @@ data:
# required: false
# - name: mono-vertex
# #expr: optional
- name: pipeline_counter_metrics
object: vertex
title: Rate of Change of metrics
description: This pattern is to calculate rate of change of counter metrics
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: forwarder_data_read_total
required_filters:
- namespace
- pipeline
- vertex
dimensions:
- name: vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,29 @@ data:
# required: false
# - name: mono-vertex
# #expr: optional
- name: pipeline_counter_metrics
object: vertex
title: Rate of Change of metrics
description: This pattern is to calculate rate of change of counter metrics
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: forwarder_data_read_total
required_filters:
- namespace
- pipeline
- vertex
dimensions:
- name: vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
filters:
- name: pod
required: false
28 changes: 27 additions & 1 deletion config/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28452,7 +28452,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -28501,6 +28501,32 @@ data:
# required: false
# - name: mono-vertex
# #expr: optional
- name: pipeline_counter_metrics
object: vertex
title: Rate of Change of metrics
description: This pattern is to calculate rate of change of counter metrics
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: forwarder_data_read_total
required_filters:
- namespace
- pipeline
- vertex
dimensions:
- name: vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down
28 changes: 27 additions & 1 deletion config/namespace-install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28340,7 +28340,7 @@ metadata:
---
apiVersion: v1
data:
config.yaml: |
config.yaml: |-
# url is a required field, it should be the url of the service to which the metrics proxy will connect
# url: service_name + "." + service_namespace + ".svc.cluster.local" + ":" + port
# example for local prometheus service
Expand Down Expand Up @@ -28389,6 +28389,32 @@ data:
# required: false
# - name: mono-vertex
# #expr: optional
- name: pipeline_counter_metrics
object: vertex
title: Rate of Change of metrics
description: This pattern is to calculate rate of change of counter metrics
expr: sum(rate($metric_name{$filters}[$duration])) by ($dimension)
params:
- name: duration
required: true
- name: start_time
required: false
- name: end_time
required: false
metrics:
- metric_name: forwarder_data_read_total
required_filters:
- namespace
- pipeline
- vertex
dimensions:
- name: vertex
# expr: optional expression for prometheus query
# overrides the default expression
- name: pod
filters:
- name: pod
required: false
kind: ConfigMap
metadata:
name: numaflow-server-metrics-proxy-config
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ui/src/types/declarations/pods.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export interface PodDetailProps {
containerName: string;
pod: Pod;
podDetails: PodDetail;
vertexId: string;
}
export interface ContainerInfoProps {
state: string;
Expand Down
Loading