Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose cleanup errors #62

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix: expose cleanup errors #62

merged 3 commits into from
Nov 18, 2024

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Nov 8, 2024

If anything fails during the cleanup, expose the error to the end-user by changing the exit status.

Fixes #59

If anything fails during the cleanup, expose the error to the end-user
by changing the exit status.
@zimbatm zimbatm requested a review from r-vdp November 8, 2024 18:23
@r-vdp
Copy link
Member

r-vdp commented Nov 8, 2024

Thanks! I will test this and get back to you

@zimbatm zimbatm force-pushed the expose-cleanup-error branch from 1acfec8 to 35f3aea Compare November 18, 2024 11:15
@zimbatm zimbatm force-pushed the expose-cleanup-error branch from 35f3aea to 51a5193 Compare November 18, 2024 11:21
@zimbatm zimbatm merged commit ccc5e1c into main Nov 18, 2024
6 checks passed
@zimbatm zimbatm deleted the expose-cleanup-error branch November 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup swallows exit codes
2 participants