-
Notifications
You must be signed in to change notification settings - Fork 38
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This changes the flow of processing to make unmatched behaviour more consistent. Before, we had been: - traversing the filesystem - comparing with the cache and only emitting files which had changed - applying the matching rules to determine which formatters should be applied to a given file - applying the formatters Now, we do the following: - traverse the filesystem - apply the matching rules to determine which formatters should be applied to a given file - compare with the cache and only emit files which have changed for formatting - apply the formatters It does mean we are applying the matching rules against files which we may not have to format, but in testing against Nixpkgs the performance impact appears negligible. This makes sense since most of the processing time will be spent in the formatters, not applying some globs to file paths. In making this change, I have refined how the statistics work to make the naming and output make more sense. Before we would output: ``` traversed 41273 files emitted 41273 files for processing formatted 34111 files (14338 changed) in 23.679s ``` Not we output: ``` traversed 43492 files matched 36059 files formatted 36059 files (19 changed) in 19.324s ``` Signed-off-by: Brian McGee <brian@bmcgee.ie>
1 parent
ed8979e
commit 0e8ffff
Showing
6 changed files
with
500 additions
and
92 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.